Overview
Request 931994 superseded
This package will deploy to OpenSUSE:Factory.
- Created by joaquinito2051
- In state superseded
- Superseded by 1063394
- Open review for Emulators / rpcs3
-
Open review for
opensuse-review-team
-
Open review for
factory-staging
Request History
joaquinito2051 created request
This package will deploy to OpenSUSE:Factory.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
dimstar_suse added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:25"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:25"
licensedigger accepted review
The legal review is accepted preliminary. The package may require actions later on.
dimstar declined review
` 21+Version: v0.0.18~git20211024` => Drop the 'v' from the Version string
28+BuildRequires: cmake(x86-64) >= 3.14.1 => no need to specify x86_64; the pkg is ExclusiveArch anyway
38+BuildRequires: -post-build-checks => policy violation. Those checks are there for a reason
84+Requires(post): hicolor-icon-theme
85+Requires(post): update-desktop-files
86+Requires(postun): hicolor-icon-theme
87+Requires(postun): update-desktop-files
132+%post
133+%desktop_database_post
134+%icon_theme_cache_post
135+
136+%postun
137+%desktop_database_postun
138+%icon_theme_cache_postun
This is all deprecated; those scripts are all %nil and have been replaced by file triggers
114+# FIXME: you should use the %%cmake macros
115+%__cmake ../%{name}-%{version} \
The comment is true
141+cd ../%{name}_build
142+%make_install
=> cmake_install
dimstar declined request
` 21+Version: v0.0.18~git20211024` => Drop the 'v' from the Version string
28+BuildRequires: cmake(x86-64) >= 3.14.1 => no need to specify x86_64; the pkg is ExclusiveArch anyway
38+BuildRequires: -post-build-checks => policy violation. Those checks are there for a reason
84+Requires(post): hicolor-icon-theme
85+Requires(post): update-desktop-files
86+Requires(postun): hicolor-icon-theme
87+Requires(postun): update-desktop-files
132+%post
133+%desktop_database_post
134+%icon_theme_cache_post
135+
136+%postun
137+%desktop_database_postun
138+%icon_theme_cache_postun
This is all deprecated; those scripts are all %nil and have been replaced by file triggers
114+# FIXME: you should use the %%cmake macros
115+%__cmake ../%{name}-%{version} \
The comment is true
141+cd ../%{name}_build
142+%make_install
=> cmake_install
dimstar_suse reopened request
Reopened via staging workflow.
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:adi:25"
dimstar_suse declined request
Declined via staging workflow.
