Request 935972 (accepted)

Overview

Request 935972 accepted

- Non-existent patches must be listed twice to appear as added in a
unified diff against a version that had them. Only that can make
factory-auto happy. Here we go:
* makedumpfile-Retrieve-MAX_PHYSMEM_BITS-from-vmcoreinfo.patch
* makedumpfile-arm64-Add-support-for-ARMv8.2-LPA-52-bit-PA-su.patch

Created by ptesarik over 2 years ago
In state accepted

Submit makedumpfile

Comments for request 935972 6

Dominique Leuenberger (dimstar) - over 2 years ago

reviewer

say what???

 5+- Non-existent patches must be listed twice to appear as added in a
 6+  unified diff against a version that had them. Only that can make
 7+  factory-auto happy. Here we go:
 8+  * makedumpfile-Retrieve-MAX_PHYSMEM_BITS-from-vmcoreinfo.patch
 9+  * makedumpfile-arm64-Add-support-for-ARMv8.2-LPA-52-bit-PA-su.patch
10+

This is probably the weirdest thing I've ever read and makes very little sense.

Dominique Leuenberger (dimstar) - over 2 years ago

reviewer

@sweiberg does that refer to a decline in SLE which was odd? e.g. patches added in a SP that are dropped in SP4 with the package update?

Petr Tesařík (ptesarik) - over 2 years ago

author source maintainer

You bet. Makedumpfile must be upgraded for SLE15 SP4 (because the kernel was updated). These two patches had to be backported into SLE15 SP3 makedumpfile:

makedumpfile-Retrieve-MAX_PHYSMEM_BITS-from-vmcoreinfo.patch
makedumpfile-arm64-Add-support-for-ARMv8.2-LPA-52-bit-PA-su.patch

However, by that time, Factory already contained a newer version, which included the changes from these two patches. That's how these patches never made it into Tumbleweed. So far so good…

Now comes the funny part. The changelog for SLE goes like this:

- Fix guessing of VA_BITS and if present use TCR_EL1_T1SZ to determine
  vabits_actual (since kernel v5.9). ([bsc#1183977](https://bugzilla.opensuse.org/show_bug.cgi?id=1183977))
  * makedumpfile-Retrieve-MAX_PHYSMEM_BITS-from-vmcoreinfo.patch
  * makedumpfile-arm64-Add-support-for-ARMv8.2-LPA-52-bit-PA-su.patch

To sync that with Factory, I added these lines (as you can see above):

- Patches that were never actually applied to Factory:
  * makedumpfile-Retrieve-MAX_PHYSMEM_BITS-from-vmcoreinfo.patch
    (included in 1.6.8)
  * makedumpfile-arm64-Add-support-for-ARMv8.2-LPA-52-bit-PA-su.patch
    (included in 1.6.8)

As it happens, the two lines with the patch names happen to match exactly, so they are seen as unchanged by factory-auto. Technically, they are not listed on a line that starts with a + when factory-auto does a unified diff. Consequently, the script concludes that the patches were removed without being mentioned:

A patch (makedumpfile-arm64-Add-support-for-ARMv8.2-LPA-52-bit-PA-su.patch) is being deleted without this removal being mentioned in the changelog.

And the submit request was declined automatically before anyone even had a chance to have a look. See comments to the corresponding IBS request: https://build.suse.de/request/show/259746

Petr Tesařík (ptesarik) - over 2 years ago

author source maintainer

For reference, the genius code that forced me to add my funny changelog entry lives here:

https://github.com/openSUSE/openSUSE-release-tools/blob/master/check_source.pl

The decision to enforce Factory-first policy for SLE with a script was made by project managers long ago against my objections. I'm between a rock and a hard place, you see.

Dominique Leuenberger (dimstar) - over 2 years ago

reviewer

sadly, https://build.suse.de/request/show/259746 is in a state that shows a totally bogus diff; making it very hard to debug. I'd have loved to see the original case

But well - let's take it like this so at least you won't have to suffer with future submissions to SP4

Petr Tesařík (ptesarik) - over 2 years ago

author source maintainer

The original file for the diff was this one:

https://build.opensuse.org/package/view_file/SUSE:SLE-15-SP3:Update/makedumpfile/makedumpfile.changes?expand=1

The new one for the request was like in Factory before accepting this submit request.

Good luck!