Overview

Request 940736 accepted

- Use %autosetup, apply patches unconditionally
- Hard depend on wireplumber-audio if pipewire-pulseaudio is installed

Loading...

Antonio Larrosa's avatar

We can change the first require to Requires: (%{name}-audio unless pulseaudio) . That would cover both pw-pa being installed and systems without pw-pa nor pa, right?


Fabian Vogt's avatar

On systems with plain alsa + pipewire, that would then forcibly pull in wireplumber-audio and recommend pipewire-pulseaudio.


Antonio Larrosa's avatar

Is that an argument in favor or against the change? :)

The question is, in such a system, do we want pipewire to handle audio? . In my opinion, if pipewire is installed and pulseaudio is not, then we want pipewire to handle audio so it's a good thing it pulls in those two packages. Note that even your changelog entry describes that behaviour "Hard depend on wireplumber-audio unless pulseaudio is installed".


Fabian Vogt's avatar

The question is, in such a system, do we want pipewire to handle audio? . In my opinion, if pipewire is installed and pulseaudio is not, then we want pipewire to handle audio

IMO no, because that would switch systems to pipewire audio, because pipewire is pulled in by various packages like chromium already as an (unintentional for the user) side effect. See also boo#1193695.

Note that even your changelog entry describes that behaviour "Hard depend on wireplumber-audio unless pulseaudio is installed".

Yes, my initial change was exactly what you proposed and I wrote the entry based on that. I changed it later but didn't update .changes.

Request History
Fabian Vogt's avatar

Vogtinator created request

- Use %autosetup, apply patches unconditionally
- Hard depend on wireplumber-audio if pipewire-pulseaudio is installed


Antonio Larrosa's avatar

alarrosa accepted request

openSUSE Build Service is sponsored by