Overview
Request 941699 accepted
- Using URLs for Patches looks like a great idea, but it is too
unstable. Please, don't.
- Add pytest-pr8664-py3.10-test_trial_error-fail.patch
* gh#pytest-dev/pytest#8664
- Add pytest-pr9417-py3.10.1-fail.patch
* gh#pytest-dev/pytest#9417
- Disable libalternatives usage until all python-pytest* packages
are on the same page (see sr#926611)
- Disable all update-alternatives install calls if libalternatives
is used.
- Use libalternatives instead of update-alternatives.
@bnavigator Using URLs for patches seems like a good idea, but I find it too unstable for us. I’ve got already plenty of errors like this. Please, don’t do it.
Merged PRs are usually safe for that. The problem was that a quilt refresh for the rebased patch also refreshed the second one.
That’s another reason … most of our patches are at least refreshed. Binary identity is really not that important.
Request History
mcepl created request
- Using URLs for Patches looks like a great idea, but it is too
unstable. Please, don't.
- Add pytest-pr8664-py3.10-test_trial_error-fail.patch
* gh#pytest-dev/pytest#8664
- Add pytest-pr9417-py3.10.1-fail.patch
* gh#pytest-dev/pytest#9417
- Disable libalternatives usage until all python-pytest* packages
are on the same page (see sr#926611)
- Disable all update-alternatives install calls if libalternatives
is used.
- Use libalternatives instead of update-alternatives.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse set openSUSE:Factory:Staging:E as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:E"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:E"
dimstar accepted review
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:E got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:E got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:E got accepted.
shouldn't that also be wrapped in
if %{with libalternatives}
?No, the check is within the macro itself.