Overview
Request 943677 superseded
Automatic submission by obs-autosubmit
- Created by factory-maintainer
- In state superseded
- Superseded by 948431
-
Open review for
opensuse-review-team
-
Open review for
factory-staging
Request History
factory-maintainer created request
Automatic submission by obs-autosubmit
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse added openSUSE:Factory:Staging:adi:32 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:32"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:32"
dimstar declined review
5+- Add explicit minimum versions for %requires_eq dependencies. This is
6+ necessary because otherwise the package appears to use exact version
7+ requirements which cause issues with updates.
Does not compute, especially when looking at
23-BuildRequires: %{use_python}-hiredis
24+BuildRequires: %{use_python}-hiredis >= 1.0.1
25+%requires_eq %{use_python}-hiredis
The minimal version dep is att he BuildRequires, which has 0 impact on the requires_eq
requires_eq means 'add a dependency on the exact same version of the package I had during build'; so whenever hiredis changes version, this package becomes uninstallable as hiredis in the version used during build no longer exists (expecting a rebuild of this package)
if you want 'I need a version equal or greater to what I had during build', then that would be %requires_ge
dimstar declined request
5+- Add explicit minimum versions for %requires_eq dependencies. This is
6+ necessary because otherwise the package appears to use exact version
7+ requirements which cause issues with updates.
Does not compute, especially when looking at
23-BuildRequires: %{use_python}-hiredis
24+BuildRequires: %{use_python}-hiredis >= 1.0.1
25+%requires_eq %{use_python}-hiredis
The minimal version dep is att he BuildRequires, which has 0 impact on the requires_eq
requires_eq means 'add a dependency on the exact same version of the package I had during build'; so whenever hiredis changes version, this package becomes uninstallable as hiredis in the version used during build no longer exists (expecting a rebuild of this package)
if you want 'I need a version equal or greater to what I had during build', then that would be %requires_ge
dimstar_suse reopened request
Reopened via staging workflow.
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:adi:32"
dimstar_suse declined request
Declined via staging workflow.
superseded by 948431
Does not compute, especially when looking at
23-BuildRequires: %{use_python}-hiredis 24+BuildRequires: %{use_python}-hiredis >= 1.0.1 25+%requires_eq %{use_python}-hiredisThe minimal version dep is att he BuildRequires, which has 0 impact on the requires_eq
requires_eq means 'add a dependency on the exact same version of the package I had during build'; so whenever hiredis changes version, this package becomes uninstallable as hiredis in the version used during build no longer exists (expecting a rebuild of this package)
if you want 'I need a version equal or greater to what I had during build', then that would be
%requires_ge