Request 944526 (accepted)

This request supersedes: request 943493 (Show diff)

Overview

Request 944526 accepted

- Update to 2.6.0
* add support for changing sub gain
* The SetEQ/GetEQ actually use i2
* Add support for volume in decibel
* add github workflows to test the build on ubuntu-latest
* show the badge of build status
* Update build-ubuntu-latest.yml
* implement the move constructor for the shared pointer
* fix const qualifier of returned shared_ptr
- Change source URL according to upstream

Created by bosim almost 3 years ago
In state accepted
Supersedes 943493

Submit noson

Comments for request 944526 2

Bo Simonsen (bosim) - almost 3 years ago

author source maintainer

No upstream changelog was provided, used the git commit log

Dominique Leuenberger (dimstar) - almost 3 years ago

reviewer

Ok, I'll let it pass like this.

For future cases, please strip things that make no sense to the end users from the changelog.

In this case, for example, I'd have skipped:

 9+  * add github workflows to test the build on ubuntu-latest
10+  * show the badge of build status
11+  * Update build-ubuntu-latest.yml 
12+  * implement the move constructor for the shared pointer
13+  * fix const qualifier of returned shared_ptr

Those seem not really relevant to a user of the package; the first three are pure developer workflow things, so in any case irrelevant; the last two are debatable, as they at least describe fixes in the code done