Please login to access the resource
Overview

Request 949686 accepted

- When we limit setuptools in Requires, we should certainly do it
in BuildRequires as well.

- Codify version requirement on setuptools for building.

Loading...

Dominique Leuenberger's avatar

5+- Codify version requirement on setuptools for building.

yet: 16+Requires: python-setuptools >= 40.9 is not 'building', that is a runtime dependency.


Jan Engelhardt's avatar

Oops.

But anyway, for the record,

[   50s] + /usr/bin/mkdir /home/abuild/rpmbuild/BUILDROOT/python-wheel-0.36.2-150300.3.1.x86_64
[   50s] + cd wheel-0.36.2
[   50s] ++ '[' -f _current_flavor ']'
[   50s] ++ true
[   50s] + last_flavor=
[   50s] + '[' -z '' ']'
[   50s] + last_flavor=tmp
[   50s] + '[' tmp '!=' python3 ']'
[   50s] + '[' -d build ']'
[   50s] + '[' -d _build.python3 ']'
[   50s] + echo python3
[   50s] + python_flavor=python3
[   50s] + /usr/bin/python3 setup.py build '--executable=/usr/bin/python3 -s'
[   50s] Download error on https://pypi.org/simple/setuptools/: [Errno -3] Temporary failure in name resolution -- Some packages may not be found!
[   50s] Download error on https://pypi.org/simple/: [Errno -3] Temporary failure in name resolution -- Some packages may not be found!
[   50s] No local packages or working download links found for setuptools>=40.9.0
[   50s] Traceback (most recent call last):
[   50s]   File "setup.py", line 4, in <module>
[   50s]     setup(maintainer=u'Alex Grönholm')
[   50s]   File "/usr/lib/python3.6/site-packages/setuptools/__init__.py", line 139, in setup
[   50s]     _install_setup_requires(attrs)
[   50s]   File "/usr/lib/python3.6/site-packages/setuptools/__init__.py", line 134, in _install_setup_requires
[   50s]     dist.fetch_build_eggs(dist.setup_requires)
[   50s]   File "/usr/lib/python3.6/site-packages/setuptools/dist.py", line 514, in fetch_build_eggs
[   50s]     replace_conflicting=True,
[   50s]   File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 777, in resolve
[   50s]     replace_conflicting=replace_conflicting
[   50s]   File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 1060, in best_match
[   50s]     return self.obtain(req, installer)
[   50s]   File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 1072, in obtain
[   50s]     return installer(requirement)
[   50s]   File "/usr/lib/python3.6/site-packages/setuptools/dist.py", line 581, in fetch_build_egg
[   50s]     return cmd.easy_install(req)
[   50s]   File "/usr/lib/python3.6/site-packages/setuptools/command/easy_install.py", line 670, in easy_install
[   50s]     raise DistutilsError(msg)
[   50s] distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('setuptools>=40.9.0')
[   50s] error: Bad exit status from /var/tmp/rpm-tmp.JvvDdz (%build)
[   50s]
[   50s]
[   50s] RPM build errors:
[   50s]     Bad exit status from /var/tmp/rpm-tmp.JvvDdz (%build)

So that means that a BuildRequires was actually missing and setuptools only made it into the build root by accident.


Dominique Leuenberger's avatar
12 BuildRequires:  %{python_module setuptools}
13 BuildRequires:  fdupes
14 BuildRequires:  python-rpm-macros >= 20210929
15-Requires:       python-setuptools
16+Requires:       python-setuptools >= 40.9

The BuildRequires is there, but not version-specific. The changed 'Requires' won't change that.

Where do you see that error anyway? This is still building for python 3.6 - which we have no longer enabled for Tumbleweed (and as such using the default scriptlets would not add py 3.6 deps)

Request History
Matej Cepl's avatar

mcepl created request

- When we limit setuptools in Requires, we should certainly do it
in BuildRequires as well.

- Codify version requirement on setuptools for building.


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:E as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:E"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:E"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:E got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:E got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:E got accepted.

openSUSE Build Service is sponsored by