This request is superseded by
request 951631
(Show diff)
You're not reviewing the full diff of
request 950800
, but the diff to the superseded
request 949496
(Show full diff)
Overview
Request 950800 superseded
Made some changes, per @dimstar, looking for another review.
- Created by sbradnick
- In state superseded
- Supersedes 949496
- Superseded by 951631
- Open review for openSUSE:Factory:Staging:adi:22
Loading...
Request History
sbradnick created request
Made some changes, per @dimstar, looking for another review.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
dimstar accepted review
licensedigger accepted review
ok
dimstar_suse added openSUSE:Factory:Staging:adi:22 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:22"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:22"
Made a few more adjustments, mainly cleaning up hardcoded dir paths to their macro equivalent.
Where does that show up? I'm not seeing it in zypper or build logs. I'd like to see it so I can determine if I've fixed it. Thanks!
https://build.opensuse.org/package/view_file/home:repo-checker/reports/openSUSE:Factory:Staging:adi:22
It's the result of the install checker bot
Ahh, thank you sir - I saw "installcheck"(w/ a link) days ago but foolishly never clicked on it. Seems so obvious now. I see it's from 8 days ago and the last set of changes are ~2 days ago - is it something that's reset (or goes away) with a run of:
osc sr -s 950800 Virtualization/hyper-v-enhanced-session openSUSE:Factory
?
installcheck is one of the adi checks; whenever the package changes (so different sources submitted) the adi will recalculate the state and thus present a new installcheck report
the problem is probably best fixed in xrdp - where /etc/xrdp is packaged in a conflicting manner:
in xrdp.spec:
so in fact it packages the entire /etc/xrdp once clean (using the %dir directive) and then again as config(noreplace), recursively
This also results in quite a lengthy warning list in the build log of xrdp:
I'll try to work out a clean fix to that; in this case, I think your package only helped expose an issue in another package
proposal fix for xrdp submitted as sr#951614
I've removed the "%dir %{_sysconfdir}/xrdp" line from my .spec file as well ; the build doesn't complain about it (not being there) and I was thinking that line was causing the issue.
Should I hold off on "osc sr -s 950800 ..." for 'hyper-v-enhanced-session' while 'xrdp' is being worked on?
No need to wait - you can submit the fix right away; my fix is also in the pipeline and they can run in parallel