Please review sources

Check script succeeded

Being evaluated by staging project "openSUSE:Factory:Staging:adi:22"

Picked "openSUSE:Factory:Staging:adi:22"

ok

26+Source: %{name}.tar.gz

Please use full URLs to source tarball, so that their content can be counter-checked against what upstream publishes (or use a _service for git checkouts)

29+# ---
30+Requires: lightdm
31+Conflicts: sddm
32+# ---

What about all the other display managers? (gdm comes to mind)

38+Recommends: icewm-default
39+Suggests: icewm-default

Recommend AND suggest? Recommends being a stronger dep than suggests makes the 2nd a NOP in all cases

+%pre
68+# ---
…

The entire pre-script happens on every subsequent updates of the package as well. Feels rude to overwrite an admin over and over (they might have wanted to change some of those values intentionally)

Same for post - it runs on each subsequent upgrade of the package (including rebuilds for example)

and I hope
106+ %{_bindir}/firewall-cmd --add-service=ms-wbt
that firewalls is smart enough to not add this more than once when re-executed over and over

115+then
116+ printf "\nRunning systemctl preset commands for xrdp, xrdp-sesman, xvnc-novnc, and vncmanager:\n"
117+ %{_bindir}/systemctl preset xrdp.service
118+ %{_bindir}/systemctl preset xrdp-sesman.service
119+ %{_bindir}/systemctl preset xvnc-novnc.socket
120+ %{_bindir}/systemctl preset vncmanager.service
121+fi

That should rather be done properly using the systemd macros, see https://en.opensuse.org/openSUSE:Systemd_packaging_guidelines#Registering_unit_files_in_install_scripts (same argument: you reset to the preset on each update of the package. The admin is not supposed having to fight against packages; the systemd macros handle the case properly)

26+Source: %{name}.tar.gz

Please use full URLs to source tarball, so that their content can be counter-checked against what upstream publishes (or use a _service for git checkouts)

29+# ---
30+Requires: lightdm
31+Conflicts: sddm
32+# ---

What about all the other display managers? (gdm comes to mind)

38+Recommends: icewm-default
39+Suggests: icewm-default

Recommend AND suggest? Recommends being a stronger dep than suggests makes the 2nd a NOP in all cases

+%pre
68+# ---
…

The entire pre-script happens on every subsequent updates of the package as well. Feels rude to overwrite an admin over and over (they might have wanted to change some of those values intentionally)

Same for post - it runs on each subsequent upgrade of the package (including rebuilds for example)

and I hope
106+ %{_bindir}/firewall-cmd --add-service=ms-wbt
that firewalls is smart enough to not add this more than once when re-executed over and over

115+then
116+ printf "\nRunning systemctl preset commands for xrdp, xrdp-sesman, xvnc-novnc, and vncmanager:\n"
117+ %{_bindir}/systemctl preset xrdp.service
118+ %{_bindir}/systemctl preset xrdp-sesman.service
119+ %{_bindir}/systemctl preset xvnc-novnc.socket
120+ %{_bindir}/systemctl preset vncmanager.service
121+fi

That should rather be done properly using the systemd macros, see https://en.opensuse.org/openSUSE:Systemd_packaging_guidelines#Registering_unit_files_in_install_scripts (same argument: you reset to the preset on each update of the package. The admin is not supposed having to fight against packages; the systemd macros handle the case properly)

Made some changes, per @dimstar, looking for another review.