Request History
wagi created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
The legal review is accepted preliminary. The package may require actions later on.
dimstar_suse set openSUSE:Factory:Staging:D as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:D"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:D"
dimstar accepted review
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:D got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:D got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:D got accepted.
Well that sounds like Version: should be
1.0~rc4.Okay, but I am not sure how things are supposed to work with the 'service' feature. After updating the _service file I execute 'osc service runall' which updates the spec file here. Given your review the _service file is not correct.
I try to figure out what's wrong with it. Though we had three previous releases with the wrong pattern already. Should we divert now? I think there wont be many release candidates from upstream, as things are calming down (just saying with my upstream maintainer hat on :))
versionrewrite-replacement should be "\1~rc\2" and not just "\1~\2". @dimstar, should I resubmit or do you want to proceed with the current submission?
Instead of trying to come up with patterns (that then need changing all the time because sometimes there is an
rcand sometimes there isn't)<param name="revision">v1.0-rc4</param> <param name="match-tag">v[01].[0-9]*</param> <param name="versionrewrite-pattern">v([^+]*)-rc([0-9]+)</param> <param name="versionrewrite-replacement">\1~\2</param>one could simply specify the replacement version
<param name="revision">v1.0-rc4</param> <param name="versionformat">1.0~rc4</param>Thanks. I agree this makes more sense. I'll change to use versionformat directly with the next update.
The problem is if we change it now, 1.0~rc4 would be < 1.0~3
I'd keep it as is for the 1.0 cycle and adjust for 1.1 (if relevant by then)
well, on factory, “downgrades” are less of a problem than in leap
yet, we don't need to provoke it for a visual detail such as this one