Request 959246 (accepted)

You're not reviewing the full diff of request 959246 , but the diff to the superseded request 958773 (Show full diff)

Overview

Request 959246 accepted

No description set

Created by wagi over 2 years ago
In state accepted
Supersedes 958773

Submit nvme-stas

Comments for request 959246 0
Comments for request 958773 4

Dominique Leuenberger (dimstar) - over 2 years ago

reviewer

32+BuildRequires: python3-gobject

This is in 98% of the cases an indice that you also want BuildRequires: gobject-introspection in order to have typelib() style provides/requires generated.

for nvme-stat, this would produce additional deps on:

typelib(GLib)
typelib(GObject)
typelib(Gio)

Daniel Wagner (wagi) - over 2 years ago

author source maintainer

Thanks for the review. Let me update it accordingly. Do you happen to have a good example which I could follow here? I tried to read up on in the documentation but either didn't find the right spot or there is not much on this topic.

Dominique Leuenberger (dimstar) - over 2 years ago

reviewer

All the work is basically done - you should just be able to accept sr#959012

As for gobject-introspection, I don't think there is a lot; the guidelines only talk about how to package the actual typelib files (and how they produce their provides) - the dep scanner is also not 'mandatory' (but is generally a very good idea; in this case the added deps are quite minor, most users would have the deps likely present - but better safe than sorry)

Daniel Wagner (wagi) - over 2 years ago

author source maintainer

Done. Thanks a lot! Really appreciated.