Overview

Request 959246 accepted

No description set
Loading...

Dominique Leuenberger's avatar

32+BuildRequires: python3-gobject

This is in 98% of the cases an indice that you also want BuildRequires: gobject-introspection in order to have typelib() style provides/requires generated.

for nvme-stat, this would produce additional deps on:

typelib(GLib)
typelib(GObject)
typelib(Gio)

Daniel Wagner's avatar
author source maintainer

Thanks for the review. Let me update it accordingly. Do you happen to have a good example which I could follow here? I tried to read up on in the documentation but either didn't find the right spot or there is not much on this topic.


Dominique Leuenberger's avatar

All the work is basically done - you should just be able to accept sr#959012

As for gobject-introspection, I don't think there is a lot; the guidelines only talk about how to package the actual typelib files (and how they produce their provides) - the dep scanner is also not 'mandatory' (but is generally a very good idea; in this case the added deps are quite minor, most users would have the deps likely present - but better safe than sorry)


Daniel Wagner's avatar
author source maintainer

Done. Thanks a lot! Really appreciated.

Request History
Daniel Wagner's avatar

wagi created request


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:44"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:adi:44"


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:adi:44 got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:adi:44 got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:adi:44 got accepted.

openSUSE Build Service is sponsored by