Overview

Request 960500 accepted

Plasma 5.24.3


Christophe Giboudeaux's avatar

Are you sure about the pam_kwallet spec change?


Wolfgang Bauer's avatar

Well, the pam_kwallet package did explicitly set -DLIBEXEC_INSTALL_DIR=%{_kf5_libexecdir} before the change to kf5-filesystem, so I think that change should be fine.

As the package is "noarch" now, there cannot be different paths for 32bit and 64bit though, so using %{_kf5_libexecdir} (which implies /usr/lib/ or /usr/lib64/ for older kf5-filesystem, depending on the arch) would be wrong... And not setting -DLIBEXEC_INSTALL_DIR would make it default to %{_kf5_libdir}/libexec (or /%{_lib}/libexec on Leap, due to the -DKDE_INSTALL_LIBDIR=/%{_lib}) I think, which would be wrong too (for the same reason).


Fabian Vogt's avatar

Yep, that was my thought process as well.

Request History
Fabian Vogt's avatar

Vogtinator created request

Plasma 5.24.3


Wolfgang Bauer's avatar

wolfi323 accepted request

LGTM. As I wrote, I think the pam-kwallet change is fine (and explicitly setting KDE_INSTALL_LIBEXECDIR is even necessary for older kf5-filesystem).

openSUSE Build Service is sponsored by