Overview
Request 961088 superseded
KDE Frameworks 5.92
- Created by cgiboudeaux
- In state superseded
- Supersedes 960666
- Superseded by 961114
kactivities-stats.spec:
+BuildRequires: cmake(KF5DBusAddons) >= %{_kf5_bugfix_version}
+BuildRequires: cmake(KF5I18n) >= %{_kf5_bugfix_version}
I don't think it makes sense to add these BuildRequires, AFAICS they are not used/looked for at all (the corresponding find_package() lines in CMakeLists.txt are commented out since 6 years: https://invent.kde.org/frameworks/kactivities-stats/-/commit/d89a7357b62ac75d3e2a42d78af2af74c5e4819c ).
kfilemetadata5:
+ * enable mobipocket extractor by default
Maybe we should add the corresponding BuildRequires: cmake(QMobipocket), so that it's actually built. The build log currently states:
[ 95s] -- The following OPTIONAL packages have not been found:
[ 95s]
[ 95s] * QMobipocket (required version >= 2.0), Mobipocket epub reader, https://invent.kde.org/graphics/kdegraphics-mobipocket
[ 95s] Support for mobi metadata
Otherwise LGTM.
This would delay builds. mobipocket is in KDE:Applications and kfilemetadata is supposed to be a tier 2 framework (ie: only depending on Qt and tier 1)
kirigami2.spec:
-Recommends: %{name}-lang = %{version}
+Recommends: libkirigami2plugin-lang = %{version}
That new change looks wrong to me: there is no package named libkirigami2plugin-lang, it is called kirigami2-lang, i.e. %{name}-lang.