Overview

Request 961567 accepted

- Simplify macros.fdupes with a call to a C++ program that does
the same within a fraction of a second what the shell loop did
in many seconds (bsc#1195709)

Jiri Slaby's avatar
Jiri Slaby (jirislaby) -

I wonder, don't you want to optimize the build (e.g. -O2)?

Stephan Kulow's avatar
Stephan Kulow (coolo) -
author

Good point

Jiri Slaby's avatar
Jiri Slaby (jirislaby) -

Another note: do symlinks work in your implementation? I thought we'd need to remove %buildroot from target in link_file().

Stephan Kulow's avatar
Stephan Kulow (coolo) -
author

I didn't even try, see my comment in bugzilla - I don't even know what's the expected output.

Kernel-firmware.spec seems to be the only spec file in Factory using -s btw

Stephan Kulow's avatar
Stephan Kulow (coolo) -
author

ok, https://github.com/bmwiedemann/openSUSE/search?q=%25fdupes+-s isn't reliable. There are quite some more.

Request History
Stephan Kulow's avatar

coolo created request

- Simplify macros.fdupes with a call to a C++ program that does
the same within a fraction of a second what the shell loop did
in many seconds (bsc#1195709)

Peter Simons's avatar

psimons accepted request

Thank you!

openSUSE Build Service is sponsored by
Places