Overview

Request 985411 accepted

- add Requires: typelib-1_0-Gtk-3_0
* fix boo#1200948

Loading...

Dominique Leuenberger's avatar

The fix is merely a workaround - essentially, the code is wrong.

It only does from gi.repository import Gtk - but without specifying what version of Gtk it wants to use.

so before the import, it should should do gi.require_version ('Gtk', '3.0')

(Otherwise, if typelib-1_0-Gtk-4_0 is also installed, the py code will pick a 'random one and still do the wrong thing.

If the code properly specifics this versioned dep, then the dep scanner should add typelib(Gtk) = 3.0 as dependency


Dominique Leuenberger's avatar
   try:
        from gi import require_version

        require_version('PangoCairo', '1.0')
        require_version('Gtk', '3.0')
        require_version('Gdk', '3.0'

oh - they do require the right versions :( but with non-standard code which the dep scanner can't detect

Request History
Giacomo Comes's avatar

gcomes.obs created request

- add Requires: typelib-1_0-Gtk-3_0
* fix boo#1200948


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse added openSUSE:Factory:Staging:adi:28 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:28"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:adi:28"


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:adi:28 got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:adi:28 got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:adi:28 got accepted.

openSUSE Build Service is sponsored by