You're not reviewing the full diff of
request 992162
, but the diff to the superseded
request 991804
(Show full diff)
Overview
Request 992162 accepted
- Initial release 0.2.1a0
- Created by Simmphonie
- In state accepted
- Supersedes 991804
Loading...
target maintainer
- Please, don’t use
%{python_sitelib}/*
, it is too general and it hides packaging problems quite well. Use something like+%{python_sitelib}/towncrier
and+%{python_sitelib}/towncrier-%{version}*-info
instead. - Please, investigate whether it would be possible to run the test suite. There seem to be some tests included even in the tarball.
author
- Okay
- There is only one config file in test drawer. I don't think there are any other tests. Could you please check it as well? I'm not sure.
target maintainer
- You are right, that’s useless.
So, please, submit a fixed version of the package for the other stuff (and supersede this SR).
Thank you.
Login required, please
login
in order to comment
It is not wrong, just awkward: if you make the package own
%{python_sitelib}/sphinxcontrib/towncrier
(without slash in the end and asterisk after it), you don’t have to add%dir
line before that.