Overview

Request 993539 accepted

- Buildrequires cached-property always, not only for Python lower than 3.8
* This is needed due to a mismatching python-rpm-macros
- Fix conditional Requires and BuildRequires.


Marina Latini's avatar

@dimstar:

the Requires: python-cached-property is needed only with Python lower than 3.8 (we need it on the SLE/Leap side).

on SLE side we have those versions of python-rpm-macros:

  • SP3 has version 20200207.5feb6c1-3.11.1
  • SP4 has version 20220106.80d3756-150400.1.44

and rpm (both SP3 and SP4) is only version 4.13.3

Do you have any alternative idea?


Dominique Leuenberger's avatar

Requires: (python-cached-property if python-base < 3.8)

'with' as documented in the spec would not do the right thing, as this would require a package python-cached-property which, the SAME package, provides python-base < 3.8. definitively not what is intended

'and' as used in your SR would be the same as splitting it simply up to

Requires: python-cached-property
Requires: python-base < 3.8

so also not what you intended.

with 'if' the boolean dep does what you want: if python-base < 3.8 is installed, we require python-cached-property (keep in mind that rpm-single-spec rewrites python topython3, python38, python39, python310, as appropriate)

Luckily, 'if' exists since RPM 4.13

Request History
Matej Cepl's avatar

mcepl created request

- Buildrequires cached-property always, not only for Python lower than 3.8
* This is needed due to a mismatching python-rpm-macros
- Fix conditional Requires and BuildRequires.


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar_suse added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:31"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:adi:31"


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:adi:31 got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:adi:31 got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:adi:31 got accepted.

openSUSE Build Service is sponsored by