Overview

Request 1058228 superseded

- Make the priority for picking the storage driver configurable (bsc#1197093)
(backport of https://github.com/containers/storage/pull/1460)
- add patch: 0002-Make-the-priority-for-picking-the-storage-driver-con.patch

Loading...

Fabian Vogt's avatar

The ------------------------------------------------------------------- separator is missing in .changes somehow (did you not use osc vc?), but otherwise LGTM


Danish Prakash's avatar
author source maintainer target maintainer

I've been using osc vc, idk how that got missed, sorry about that.


Fabian Vogt's avatar

That looks like you added your own header instead of using the commits.

It has to look like https://github.com/containers/storage/pull/1460/commits/881ac4864a79b830f271e6d36164b8c8abb02062.patch


Danish Prakash's avatar
author source maintainer target maintainer

Thanks for noticing, I had to update the patch, and git added me as author while generating the patch again. Will fix.


Fabian Vogt's avatar

That sounds like you added the raw diff instead of checking out the git repo or importing the complete patches. Otherwise git keeps authorship info intact by default.


Danish Prakash's avatar
author source maintainer target maintainer

You're right. I guess I was confused because this is a vendor patch and I'm not sure If I could've used git to apply that raw patch I got off the upstream git repo (c/storage) because those files aren't there in git's index in c/podman. Please let me know if there's a better way to do this? Thanks


Fabian Vogt's avatar

You could try git am --directory vendor/github.com/containers/storage with the patches from the storage repo


Danish Prakash's avatar
author source maintainer target maintainer

Thank you, that seems to have worked perfectly. Required the --reject flag for dealing with conflicts manually and then merging the 2 patches via stdout. Thanks!

Request History
Danish Prakash's avatar

danishprakash created request

- Make the priority for picking the storage driver configurable (bsc#1197093)
(backport of https://github.com/containers/storage/pull/1460)
- add patch: 0002-Make-the-priority-for-picking-the-storage-driver-con.patch


Danish Prakash's avatar

danishprakash superseded request

superseded by 1058234

openSUSE Build Service is sponsored by