Request 1068416 (superseded)

This request is superseded by request 1068695 (Show diff)

Overview

Request 1068416 superseded

No description set

Created by adamm over 1 year ago
In state superseded
Superseded by 1068695
Open review for openSUSE:Factory:Staging:F

Submit qpdf

Comments for request 1068416 6

Dominique Leuenberger (dimstar) - over 1 year ago

reviewer

Breaks cups-filters

https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:D/cups-filters/standard/x86_64

Adam Majer (adamm) - over 1 year ago

author source maintainer

looks like a simple fix, if that's the only problem.. I'll fix it.

Dominique Leuenberger (dimstar) - over 1 year ago

reviewer

It's the only package in ring1 building against qpdf

the others are non-ring and you might want to check / validate them:

qpdf :
   cups-filters
   paperjam
   pdfmixtool
   python-img2pdf
   python-pikepdf

Adam Majer (adamm) - over 1 year ago

author source maintainer

python-* is unaffected because it uses -std=c++17, so it compiles fine. The other two are affected and now I submitted patches there. Found that paperjam doesn't use ditro flags, so fixed that too

https://build.opensuse.org/request/show/1068470 https://build.opensuse.org/request/show/1068463

Dominique Leuenberger (dimstar) - over 1 year ago

reviewer

Perfect! Thanks a lot

Adam Majer (adamm) - over 1 year ago

author source maintainer

So, initially, I thought something is wrong with headers in qpdf. It was not. The reason is qpdf requires C++17 feature (std::string_view) and cups-filters is explicitly setting the feature set to C++11. After I removed all the -std= hacks and use compiler default instead, everything is building again...

Sent patch for cups-filters to the devel project and will check the other 4 packages now too.

https://build.opensuse.org/request/show/1068456