Overview

Request 1068695 accepted

No description set
Loading...


Adam Majer's avatar
author source maintainer

looks like a simple fix, if that's the only problem.. I'll fix it.


Dominique Leuenberger's avatar

It's the only package in ring1 building against qpdf

the others are non-ring and you might want to check / validate them:

qpdf :
   cups-filters
   paperjam
   pdfmixtool
   python-img2pdf
   python-pikepdf

Adam Majer's avatar
author source maintainer

python-* is unaffected because it uses -std=c++17, so it compiles fine. The other two are affected and now I submitted patches there. Found that paperjam doesn't use ditro flags, so fixed that too

https://build.opensuse.org/request/show/1068470 https://build.opensuse.org/request/show/1068463


Dominique Leuenberger's avatar

Perfect! Thanks a lot


Adam Majer's avatar
author source maintainer

So, initially, I thought something is wrong with headers in qpdf. It was not. The reason is qpdf requires C++17 feature (std::string_view) and cups-filters is explicitly setting the feature set to C++11. After I removed all the -std= hacks and use compiler default instead, everything is building again...

Sent patch for cups-filters to the devel project and will check the other 4 packages now too.

https://build.opensuse.org/request/show/1068456

Request History
Adam Majer's avatar

adamm created request


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:F as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:F"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:F"


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:F got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:F got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:F got accepted.

openSUSE Build Service is sponsored by