This request is superseded by
request 1132487
(Show diff)
Overview
Request 1132212 superseded
- Add explicitly-include-unistd.patch and specify higher version of
gcc to build on SLE/Leap.
- Created by yfjiang
- In state superseded
- Superseded by 1132487
- Open review for gnome-maintainers
Loading...
Request History
yfjiang created request
- Add explicitly-include-unistd.patch and specify higher version of
gcc to build on SLE/Leap.
gnome-review-bot accepted review
Check script succeeded
superseded by 1132487
PatchX: lines should never be conditional - only applying the patches should be. This would result in .src.rpm that are not used across versions (i.e the TW.src.rpm could not build on Leap 15.x, as the relevant patch is not part of the .src.rpm; not an issue for 'us' with OBS, but there might be usecases outside of SUSE
Thanks, am I right this has to be a condition during patching, when %autosetup feature could not be used. Instead I should apply the patches one by one?
sadly yes (or you'd need something like %autopatch -M, which is, afaik, not supported in SLE - i.e specify a max p[catch ID to apply and do the rest manually