Overview

Request 1132487 accepted

- Add explicitly-include-unistd.patch and specify higher version of
gcc to build on SLE/Leap.

Loading...

Dominique Leuenberger's avatar

PatchX: lines should never be conditional - only applying the patches should be. This would result in .src.rpm that are not used across versions (i.e the TW.src.rpm could not build on Leap 15.x, as the relevant patch is not part of the .src.rpm; not an issue for 'us' with OBS, but there might be usecases outside of SUSE


Yifan Jiang's avatar
author reviewer source maintainer

Thanks, am I right this has to be a condition during patching, when %autosetup feature could not be used. Instead I should apply the patches one by one?


Dominique Leuenberger's avatar

sadly yes (or you'd need something like %autopatch -M, which is, afaik, not supported in SLE - i.e specify a max p[catch ID to apply and do the rest manually

Request History
Yifan Jiang's avatar

yfjiang created request

- Add explicitly-include-unistd.patch and specify higher version of
gcc to build on SLE/Leap.


GNOME Review Bot's avatar

gnome-review-bot accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar approved review


Dominique Leuenberger's avatar

dimstar accepted request

openSUSE Build Service is sponsored by