Overview

Request 1167695 superseded

HI @badshah400 I executed all the requests, is something missing?

Loading...

Atri Bhattacharya's avatar

Yes, you are missing several important fixes and I would appreciate if you went back to the previous sr and went over my comments point by point again.

Furthermore, it seems you have now dropped the leading lib from packages like %{name}-onnx-frontend which are actually shared libraries. This is wrong.

I would appreciate if you take your time and fix each and every issue reviewers have pointed out before you make the next sr. Please also read this thoroughly to understand the shared library packaging policy: https://en.opensuse.org/openSUSE:Shared_library_packaging_policy


Alessandro de Oliveira Faria's avatar

Hi @badshah400,

I made a huge mess, removed the libs from all packages in name.

I should only remove the plugins, I'm correcting this, there's something else that I'm not seeing.

Sorry for the inconvenience and thank you for your patience.


Atri Bhattacharya's avatar

Nothing is a huge mess, take it easy!

I believe you missed my previous comments about avoiding unnecessary use of %dir in file lists and using post and postun scriptlets only for shared library packages and for nothing else.

Please have a look at my comments again in sr#1167613

Request History
Alessandro de Oliveira Faria's avatar

cabelo created request

HI @badshah400 I executed all the requests, is something missing?


Atri Bhattacharya's avatar

badshah400 declined request


openSUSE Build Service is sponsored by