Overview
Request 1167860 superseded
Hi @badshah400,
I'm praying I've erased all my mistakes.
When I remove %dir %{_datadir}/openvino, I get the error: directories not owned by a package
- Created by cabelo
- In state superseded
- Supersedes 1167695
- Superseded by 1168415
Yes, you are missing several important fixes and I would appreciate if you went back to the previous sr and went over my comments point by point again.
Furthermore, it seems you have now dropped the leading lib from packages like %{name}-onnx-frontend which are actually shared libraries. This is wrong.
I would appreciate if you take your time and fix each and every issue reviewers have pointed out before you make the next sr. Please also read this thoroughly to understand the shared library packaging policy: https://en.opensuse.org/openSUSE:Shared_library_packaging_policy
Hi @badshah400,
I made a huge mess, removed the libs from all packages in name.
I should only remove the plugins, I'm correcting this, there's something else that I'm not seeing.
Sorry for the inconvenience and thank you for your patience.
Nothing is a huge mess, take it easy!
I believe you missed my previous comments about avoiding unnecessary use of %dir in file lists and using post and postun scriptlets only for shared library packages and for nothing else.
Please have a look at my comments again in sr#1167613
Request History
cabelo created request
Hi @badshah400,
I'm praying I've erased all my mistakes.
When I remove %dir %{_datadir}/openvino, I get the error: directories not owned by a package
badshah400 declined request
Let me copy paste from my comment in the previous sr:
You do not have to own directories individually using %dir if they are exclusive to a specific package. For example, get rid of all the lines listed under %files -n %{name}-sample and simply put
%{_datadir}/%{name}/instead.I literally wrote down precisely what to list under file lists and no more, yet you insist on overlooking or misunderstanding it. Sorry but this is getting a bit frustrating.
Even packages like
%files -n lib%{name}-tensorflow-frontend %dir %{_libdir}/openvino-%{version} %{_libdir}/libopenvino_tensorflow_frontend.so.%{version} %{_libdir}/libopenvino_tensorflow_frontend.so.%{libversion}have
%dirwhich have no business being there!sorry!!!!!!!!!!!!!!!!!!!!!!!!!!! now I understand everything
Told you repeatedly to take you time, read reviews carefully and submit a final, correct version. Yet, there are still issues you have been repeatedly warned about and I think I shall stop wasting my time reviewing any more of this. If anyone else wants to take over fine by me.
@badshah400 Sorry, I'll go through item by item.
But I confess that I don't understand or I don't see the error.
now I understand everything