Overview

Request 158103 superseded

(forwarded request 158090 from Mailaender)

Loading...
Request History
Ismail Dönmez's avatar

namtrac created request

(forwarded request 158090 from Mailaender)


Saul Goodman's avatar

licensedigger accepted review

{"approve": "preliminary, version number changed"}


Factory Auto's avatar

factory-auto added a reviewer

the package is still building for repository openSUSE_Factory


Factory Auto's avatar

factory-auto added a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Builds for repo openSUSE_Factory


Andreas Jaeger's avatar

a_jaeger declined review

You do not apply the following two patches:
-# PATCH-FIX-OPENSUSE ppc.patch dvaleev@suse.com -- fix ppc build failures
-Patch4: ppc.patch
-# PATCH-FIX-UPSTREAM mono-core-target-4.0.patch dimstar@opensuse.org -- Use runtime 4.0 as default for cairo and nunit
-Patch5: mono-core-target-4.0.patch

There's no reason stated in the changes file why those are not needed anymore and
they are still part of the sources.

So, if this is intented:
* Really remove them from sources
* Mention it in the changes file.

Since patch4 is an openSUSE fix for ppc, I suggest that you really check that
mono-core continues to build for ppc if you remove it.

So, please enable building for ppc and ppc64.


Andreas Jaeger's avatar

a_jaeger declined request

You do not apply the following two patches:
-# PATCH-FIX-OPENSUSE ppc.patch dvaleev@suse.com -- fix ppc build failures
-Patch4: ppc.patch
-# PATCH-FIX-UPSTREAM mono-core-target-4.0.patch dimstar@opensuse.org -- Use runtime 4.0 as default for cairo and nunit
-Patch5: mono-core-target-4.0.patch

There's no reason stated in the changes file why those are not needed anymore and
they are still part of the sources.

So, if this is intented:
* Really remove them from sources
* Mention it in the changes file.

Since patch4 is an openSUSE fix for ppc, I suggest that you really check that
mono-core continues to build for ppc if you remove it.

So, please enable building for ppc and ppc64.


Ismail Dönmez's avatar

namtrac superseded request

superseded by 159964

openSUSE Build Service is sponsored by