Overview
Request 492010 superseded
- Created by stroeder
- In state superseded
- Superseded by 503664
-
Open review for
factory-repo-checker
-
Open review for
factory-staging
Request History
stroeder created request
factory-auto added factory-repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
staging-bot set openSUSE:Factory:Staging:G as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:G"
staging-bot accepted review
Picked openSUSE:Factory:Staging:G
licensedigger accepted review
ok
maxlin_factory accepted review
Re-evaluation needed
maxlin_factory added factory-staging as a reviewer
Requesting new staging review
maxlin_factory set openSUSE:Factory:Staging:B as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:B"
maxlin_factory accepted review
Picked openSUSE:Factory:Staging:B
maxlin_factory accepted review
Re-evaluation needed
maxlin_factory added factory-staging as a reviewer
Requesting new staging review
maxlin_factory set openSUSE:Factory:Staging:G as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:G"
maxlin_factory accepted review
Picked openSUSE:Factory:Staging:G
maxlin_factory accepted review
Re-evaluation needed
maxlin_factory added factory-staging as a reviewer
Requesting new staging review
maxlin_factory set openSUSE:Factory:Staging:G as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:G"
maxlin_factory accepted review
Picked openSUSE:Factory:Staging:G
maxlin_factory accepted review
Re-evaluation needed
maxlin_factory added factory-staging as a reviewer
Requesting new staging review
maxlin_factory set openSUSE:Factory:Staging:G as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:G"
maxlin_factory accepted review
Picked openSUSE:Factory:Staging:G
maxlin_factory accepted review
Removing from openSUSE:Factory:Staging:G, re-evaluation needed
maxlin_factory added factory-staging as a reviewer
Requesting new staging review
maxlin_factory set openSUSE:Factory:Staging:G as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:G"
maxlin_factory accepted review
Picked openSUSE:Factory:Staging:G
maxlin_factory accepted review
Removing from openSUSE:Factory:Staging:G, re-evaluation needed
maxlin_factory added factory-staging as a reviewer
Requesting new staging review
dimstar_suse set openSUSE:Factory:Staging:H as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:H"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:H
factory-repo-checker reopened review
maxlin_factory accepted review
Removing from openSUSE:Factory:Staging:H, re-evaluation needed
maxlin_factory added factory-staging as a reviewer
Requesting new staging review
factory-repo-checker declined request
Then please change the dnscrypt setting as discussed in the comments
This introduces a cycle between libubound-mini and libsodium; can libsodium-devel please only be BuildRequired in the -non-mini case?
Maybe I'm overlooking something but both .spec files have:
BuildRequires: libsodium-devel
See also the diff: https://build.opensuse.org/request/show/491023
Maybe the cycle is caused by something else?
new cycle edge we detected are - New edges: [('libunbound-devel-mini', 'libsodium')]
so dimstar's question is about whether libsodium really need to be build required in libunbound-devel-mini or can be fine just for unbound(main package).
BuildRequires: libsodium-devel because of --enable-dnscrypt. We could disable dns-crypt support (experimental anyway) for now to get this upstream release out of the door.
Does --enable-dnscrypt change the ABI of the package?
Generally, we should try to keep the -mini variant as small as possible; it is NEVER used on a workstation, but only inside the build system to break cycles. So all features that do not impact ABI should be disabled.
Frankly I don't know whether --enable-dnscrypt changes ABI or not. As said we should probably simply disable dns-crypt support for now.
build cycle issue is not clear now