Overview

Request 503664 superseded

update to upstream release 1.6.3

Loading...

Dominique Leuenberger's avatar

The entire conversation from https://build.opensuse.org/request/show/492010 still holds true - is sodium needed for the mini package? I'd prefer not!


Dominique Leuenberger's avatar

Causes new cycle between libunbound-devel-mini and libsodium


Dominique Leuenberger's avatar

This introduces a cycle between libubound-mini and libsodium; can libsodium-devel please only be BuildRequired in the -non-mini case?


Michael Ströder's avatar

Maybe I'm overlooking something but both .spec files have:

BuildRequires: libsodium-devel

See also the diff: https://build.opensuse.org/request/show/491023

Maybe the cycle is caused by something else?


Max Lin's avatar

new cycle edge we detected are - New edges: [('libunbound-devel-mini', 'libsodium')]

so dimstar's question is about whether libsodium really need to be build required in libunbound-devel-mini or can be fine just for unbound(main package).


Michael Ströder's avatar

BuildRequires: libsodium-devel because of --enable-dnscrypt. We could disable dns-crypt support (experimental anyway) for now to get this upstream release out of the door.


Dominique Leuenberger's avatar

Does --enable-dnscrypt change the ABI of the package?

Generally, we should try to keep the -mini variant as small as possible; it is NEVER used on a workstation, but only inside the build system to break cycles. So all features that do not impact ABI should be disabled.


Michael Ströder's avatar

Frankly I don't know whether --enable-dnscrypt changes ABI or not. As said we should probably simply disable dns-crypt support for now.


Yuchen Lin's avatar

build cycle issue is not clear now

Request History
Michael Ströder's avatar

stroeder created request

update to upstream release 1.6.3


Factory Auto's avatar

factory-auto added factory-repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Yuchen Lin's avatar

maxlin_factory set openSUSE:Factory:Staging:L as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:L"


Yuchen Lin's avatar

maxlin_factory accepted review

Picked openSUSE:Factory:Staging:L


Factory Repo Checker's avatar

factory-repo-checker reopened review


Dominique Leuenberger's avatar

dimstar_suse accepted review

Removing from openSUSE:Factory:Staging:L, re-evaluation needed


Dominique Leuenberger's avatar

dimstar_suse added factory-staging as a reviewer

Requesting new staging review


Factory Repo Checker's avatar

factory-repo-checker accepted review

Builds for repo server:dns/openSUSE_Tumbleweed


Factory Repo Checker's avatar

factory-repo-checker superseded request

superseded by 506460

openSUSE Build Service is sponsored by