Overview
Request 517217 superseded
- Created by guohouzuo
- In state superseded
- Superseded by 518666
-
Open review for
legal-auto
- Open review for openSUSE:Factory:Staging:adi:99
Request History
guohouzuo created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
dimstar_suse added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:99"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:adi:99
repo-checker accepted review
cycle and install check passed
namtrac declined review
+if ! getent group %user_group >/dev/nulll; then
One "l" too much there
namtrac declined request
+if ! getent group %user_group >/dev/nulll; then
One "l" too much there
guohouzuo reopened request
@namtrac it's not a problem.
namtrac declined review
Please fix your wrong usage of /dev/null and resubmit. I wouldn't reject it if it's not a problem. We require submissions to be correct.
namtrac declined request
Please fix your wrong usage of /dev/null and resubmit. I wouldn't reject it if it's not a problem. We require submissions to be correct.
superseded by 518666
@namtrac please elaborate on "wrong usage of /dev/null" - how is it incorrect?
At least in once instance, you have an invalid dev node name
thanks!