Request 546359 (superseded)

This request is superseded by request 557687 (Show diff)

Overview

Request 546359 superseded

No description set

Created by pluskalm about 7 years ago
In state superseded
Superseded by 557687
Open review for openSUSE:Factory:Staging:N

Submit cmake

Comments for request 546359 16

Dominique Leuenberger (dimstar) - about 7 years ago

reviewer

okular fails to build

[   67s] CMake Error in generators/spectre/CMakeLists.txt:
[   67s]   Cannot find source file:
[   67s] 
[   67s]     MODULE
[   67s] 
[   67s]   Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
[   67s]   .hxx .in .txx

not guaranteed to be cmake related, but chances are high

CC @luca_b @Vogtinator @alarrosa @wolfi323 @cgiboudeaux

Christophe Giboudeaux (cgiboudeaux) - about 7 years ago

fixed upstream, will be part of Okular from 17.12

Christophe Giboudeaux (cgiboudeaux) - about 7 years ago

https://cgit.kde.org/okular.git/commit/?id=f777e2a92 is the commit

Dominique Leuenberger (dimstar_suse) - about 7 years ago

reviewer target maintainer

Needs KDE Applications 17.12 to land

Dominique Leuenberger (dimstar_suse) - almost 7 years ago

reviewer target maintainer

Unignored: returned to active backlog.

Dominique Leuenberger (dimstar) - almost 7 years ago

reviewer

Likely also related to the failure of libkollab-qt5:

[   64s] -- Detecting CXX compile features - done
[   64s] CMake Deprecation Warning at /usr/share/cmake/Modules/FeatureSummary.cmake:671 (message):
[   64s]   SET_PACKAGE_INFO is deprecated.  Use SET_PACKAGE_PROPERTIES instead.
[   64s] Call Stack (most recent call first):
[   64s]   cmake/modules/MacroLogFeature.cmake:96 (SET_PACKAGE_INFO)
[   64s]   CMakeLists.txt:61 (macro_log_feature)
[   64s] 
[   64s] 
[   64s] -- Boost version: 1.65.1
[   64s] CMake Error at cmake/modules/FindSWIG.cmake:4 (find_package_handle_standard_args):
[   64s]   Unknown CMake command "find_package_handle_standard_args".
[   64s] Call Stack (most recent call first):
[   64s]   CMakeLists.txt:80 (find_package)
[   64s] 
[   64s]

Christophe Giboudeaux (cgiboudeaux) - almost 7 years ago

there's a DR for libkolab-qt5. SR#555251

Wolfgang Bauer (wolfi323) - almost 7 years ago

And the libkolab-qt5 build failure is rather related to the KDE Applications update AFAICT (kcalcore in particular).

It already fails with cmake 3.9.5 (and even 3.5.2 on Leap 42.x) in KDE:Applications.

Luca Beltrame (luca_b) - almost 7 years ago

libkolab-qt5 will no longer be needed with Applications 17.12. Once I file them for submission, I'll also file a DR for libkolab-qt5.

Wolfgang Bauer (wolfi323) - almost 7 years ago

Fixing this cmake error will just result in compile failures later on anyway because of the API changes in kcalcore.

Christophe Giboudeaux (cgiboudeaux) - almost 7 years ago

where ?

Wolfgang Bauer (wolfi323) - almost 7 years ago

Everywhere. kcalcore has been ported from KTimeZone to QTimeZone, KDateTime to QDateTime, and so on. And that's reflected in the API.

The fix for this cmake error in libkolab-qt5 would be easy btw: sed -i '1 a include(FindPackageHandleStandardArgs)' cmake/modules/FindSWIG.cmake

But it would still be necessary to port it to the new API, which is far from easy...

Wolfgang Bauer (wolfi323) - almost 7 years ago

PS: see https://cgit.kde.org/kcalcore.git/commit/?h=Applications/17.12&id=df84459e75cec10d7460af38cc3358e9eace10d0 e.g., but it hasn't been done in a single commit...

Christophe Giboudeaux (cgiboudeaux) - almost 7 years ago

I'm afraid this discussion is getting nowhere. There's no need to fix something we're removing from factory nor fix some code nothing uses.

Wolfgang Bauer (wolfi323) - almost 7 years ago

Well, I just replied to your question... ;-)

Christophe Giboudeaux (cgiboudeaux) - almost 7 years ago

That's (one of) the reason(s) why upstream ships a libkolab copy within kdepim-runtime. Contributing to libkolab is a pain for various reasons.

Request History

pluskalm created request about 7 years ago

factory-auto added opensuse-review-team as a reviewer about 7 years ago

Please review sources

factory-auto added repo-checker as a reviewer about 7 years ago

Please review build success

factory-auto accepted review about 7 years ago

Check script succeeded

licensedigger accepted review about 7 years ago

staging-bot set openSUSE:Factory:Staging:G as a staging project about 7 years ago

Being evaluated by staging project "openSUSE:Factory:Staging:G"

staging-bot accepted review about 7 years ago

Picked openSUSE:Factory:Staging:G

namtrac accepted review about 7 years ago

lgtm

dimstar_suse accepted review about 7 years ago

Removing from openSUSE:Factory:Staging:G, re-evaluation needed

dimstar_suse added factory-staging as a reviewer about 7 years ago

Requesting new staging review

dimstar_suse set openSUSE:Factory:Staging:N as a staging project almost 7 years ago

Being evaluated by staging project "openSUSE:Factory:Staging:N"

dimstar_suse accepted review almost 7 years ago

Picked openSUSE:Factory:Staging:N

repo-checker accepted review almost 7 years ago

cycle and install check passed

factory-repo-checker superseded request almost 7 years ago

superseded by 557687

Places

Overview