This request is superseded by
request 644490
(Show diff)
Overview
Request 605312 superseded
No description set
- Created by tsaupe
- In state superseded
- Superseded by 644490
-
Open review for
factory-staging
-
Open review for
repo-checker
Loading...
Request History
tsaupe created request
licensedigger accepted review
ok
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
dimstar declined review
use single [ (no bashism if possible) and change the expression to use ||. if you use && and the condition fails the whole script fails.
dimstar declined request
use single [ (no bashism if possible) and change the expression to use ||. if you use && and the condition fails the whole script fails.
superseded by 644490
use single [ and change the expression to use ||. if you use && and the condition fails the whole script fails.
I don't think you need to use || here, using && should be fine and should make the whole expression much more readable IMHO.
No, @lnussel is right here...
if you use ^^, you end up with:
(if /test is not writable - the exit code of the script would be 1, meaning an error for rpm)
I was assuming rpm was using "set -e" when running its scriptlets. If so I don't think the code snippet you showed won't trigger an error.
s/wont/will
just to make sure, you mean something like that:
[ ! -w %{_sysconfdir}/machine-id ] || chmod 444 %{_sysconfdir}/machine-id
?
yup