Overview
Request 644490 superseded
- Upgrade to v239 (commit 6d8584e7e8e5d13d2bab49b9e6f6d2ec39759978)
- Created by fbui
- In state superseded
- Supersedes 605312 634922 635663
- Superseded by 646431
-
Open review for
legal-auto
-
Open review for
repo-checker
- Open review for openSUSE:Factory:Staging:M
use single [ and change the expression to use ||. if you use && and the condition fails the whole script fails.
I don't think you need to use || here, using && should be fine and should make the whole expression much more readable IMHO.
No, @lnussel is right here...
if you use ^^, you end up with:
#[ -w /test ] && echo writable # echo $? 1
(if /test is not writable - the exit code of the script would be 1, meaning an error for rpm)
I was assuming rpm was using "set -e" when running its scriptlets. If so I don't think the code snippet you showed won't trigger an error.
just to make sure, you mean something like that:
[ ! -w %{_sysconfdir}/machine-id ] || chmod 444 %{_sysconfdir}/machine-id
?
Request History
fbui created request
- Upgrade to v239 (commit 6d8584e7e8e5d13d2bab49b9e6f6d2ec39759978)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
jengelh accepted review
staging-bot set openSUSE:Factory:Staging:E as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:E"
staging-bot accepted review
Picked openSUSE:Factory:Staging:E
dimstar set openSUSE:Factory:Staging:M as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:M"
dimstar accepted review
Moved to openSUSE:Factory:Staging:M
dimstar_suse superseded request
superseded by 646431
@dimstar_suse, @factory-repo-checker: review reminder
That is not really new, is it.. strange this was not caught previously when shepherd was added.
is IS new - as systemd-mini did not have those files bevore... and shepherd-bins is 'only' conflicting with systemd, not with systemd-mini
Would making systemd-mini-sysvinit provide "systemd-sysvinit" help ?
Actually all "mini" versions should provide the functionality of their counterpart.
It looks like shepherd-bins is installed in a chroot environment. does anybody know why ?
Not sure why you think so. The bot checks all packages in the distro against each others
I wasn't aware that the bot does that actually.
This should be a problem since all *-mini variants should have files that conflict with their counterpart, no ?