Request 627637 (accepted)

This request supersedes: request 627628 (Show diff)

Overview

Request 627637 accepted

- Switch to multibuild to run tests
- Drop doc subpkg, they have compiled docu on web, much better
* Drops patch for_sphinx.patch

- Version update to 4.1.1:
* Fixes on python 3.x

Created by scarabeus_iv almost 6 years ago
In state accepted
Supersedes 627628

Submit python-pbr

Comments for request 627637 0
Comments for request 627628 9

Dominique Leuenberger (dimstar) - almost 6 years ago

reviewer

+Requires: this-is-only-for-build-envs

why? The -test should not contain the python code - at best you'd publish a test log in the package there; special tricks to make this not-installable seems weird here

Tomáš Chvátal (scarabeus_iv) - almost 6 years ago

author

It is a shortest way that makes the tests being run while not having to rewrite the whole %files section.

Dominique Leuenberger (dimstar) - almost 6 years ago

reviewer

Lazyness is no excuse for crap, sorry

Tomáš Chvátal (scarabeus_iv) - almost 6 years ago

author

That is not laziness the package will not install any files, so it is better to just block it than to create empty files with license.

Dominique Leuenberger (dimstar) - almost 6 years ago

reviewer

The test log in the files section would be value - as it could be inspected

Dominique Leuenberger (dimstar) - almost 6 years ago

reviewer

(the problem with this is that the bot won't find an installable solution - which in turn means it needs be white listed; all the 'only-for-build-env' whitelists are for the sake of bootstrap/cycles, and not for sake of publishing unusable stuff into the repo)

Tomáš Chvátal (scarabeus_iv) - almost 6 years ago

author

You can have empty package like python-canonicaljson.spec Or have it much more readable with just one conflict, i will go for readable over empty package any day.

Dominique Leuenberger (dimstar) - almost 6 years ago

reviewer

I frankly don't see this as a proper solution to the problem at hand; readable maybe... but still crap

The test doesn't even run against the 'exact' files we deliver to the user; and with TW not doing full rebuilds of the entire distro all the time, there is not even a relation establishable between rebuilds of the delivered package vs what the test ran against. This test is a pure proforma thing for somebodys conscious - but the value is questionable

Dominique Leuenberger (dimstar) - almost 6 years ago

reviewer

(we had a very similar issue in meson/meson-testsuite - where the testsuite package intentionally was done to use meson (the package we deliver) to use for the test suite, intentionally removing all sources that could possibly interfere... we want to test what we deliver after all)