Overview
Request 628544 superseded
- Update to 2.0.26
- Created by jengelh
- In state superseded
- Superseded by 630061
-
Open review for
repo-checker
- Open review for openSUSE:Factory:Staging:I
Request History
jengelh created request
- Update to 2.0.26
licensedigger accepted review
ok
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
staging-bot set openSUSE:Factory:Staging:E as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:E"
staging-bot accepted review
Picked openSUSE:Factory:Staging:E
namtrac accepted review
dimstar declined review
[ 104s] /usr/include/SDL/SDL_gfxPrimitives.h:38:10: fatal error: SDL.h: No such file or directory
SDL_gfx-devel should thus have a dependency on SDL-devel
dimstar declined request
[ 104s] /usr/include/SDL/SDL_gfxPrimitives.h:38:10: fatal error: SDL.h: No such file or directory
SDL_gfx-devel should thus have a dependency on SDL-devel
jengelh reopened request
please fix mjpegtools; it completely lacks the output of `pkg-config SDL_gfx --cflags`
dimstar_suse accepted review
Re-evaluation needed
dimstar_suse added factory-staging as a reviewer
Requesting new staging review
staging-bot set openSUSE:Factory:Staging:I as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:I"
staging-bot accepted review
Picked openSUSE:Factory:Staging:I
dimstar_suse superseded request
superseded by 630061
mjpegtools fails with with this:
As SDL/SDL_gxfPrimitives includes SDL.h, the dependency on it should come from SDL_gfx in this case (not mjpegtools buildrequiring it)
SDL_gfx does have the dep:
Maybe you need to tell mjpegtools to actualy use pkgconfig. It's not like SDL_gfx 1.x had any real change with regards to headers (I believe).
SDL_gfx changed an
#include "SDL.h"to#include <SDL.h>. That is not an incorrect move, but it causes "." relative to SDL_gfxPrimitives.h not to be necessarily searched. The bug is with mjpegtools which fails to obtain pkg-config flags from SDL_gfx.pc.