Overview
Request History
theMarix created request
Add package gamemode to Factory. For further info on the submission see https://lists.opensuse.org/opensuse-factory/2018-08/msg00184.html.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
staging-bot added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:67"
staging-bot accepted review
Picked openSUSE:Factory:Staging:adi:67
repo-checker accepted review
cycle and install check passed
namtrac accepted review
reviewed_ok, you can change to full source URL if you want.
licensedigger accepted review
ok
staging-bot accepted review
ready to accept
staging-bot approved review
ready to accept
dimstar_suse accepted request
Accept to openSUSE:Factory
@theMarix please use full source URL: https://en.opensuse.org/SourceUrls
Thanks for your suggestion. I see your point but sadly it is completely unclear to me how I should put a full URL as the tarball is generated via obs_scm and not retrieved via download_url. I assumed this to be the current best practice. Is is not?
When there is no released tarball a _service is fine but I see https://github.com/FeralInteractive/gamemode/archive/1.2.tar.gz which should work?
Keep in mind that using _services like tar_scm and obs_scm are perfectly acceptable; full source urls are only useful if the packager decides to use released tarballs (often they are pre-bootstrapped, so they can make things easier, and sometimes there can also be signatures next to them... but it is not mandated)
As far as I know those tarballs are generated on the fly. Thus, I would doubt they even generate the same check sum every time as file iteration order is file-system-state dependent.
Thanks for the review!