Overview
Hello Guys,
Please help to review this request asap, the whole change(lvm2_v2_02_180) from my home project is not too much big, but the project will fix lvm2 two key feature problems (lvm2 mirror LV and pvmove), second, our 12sp4 project is being blocked by this factory submission.
Thanks Gang
Hi Guys,
Please help to review this request asap, since our 12sp4 project is being blocked by this factory submission.
Thanks Gang
I'll try to find a staging space for this asap - with the issues around openQA of last week, things started piling up more than thet should.
OTOH: the changelog is clearly incomplete.
+- Update to LVM2.2.02.180
The standard decline message, which should have been given by @namtrac is:
Please be a bit more verbose in the changes entry ... (not just version number). Please read https://en.opensuse.org/openSUSE:Howto_write_good_changes for more details about a good changelog entry.
Or the ordering is a bit strange - some of the fixes mentioned are likely to be attributed to the update; possibly Ismail was nice enough to interpret it that way :)
The wording "Drop upstream patches" is a bit confusing - one could read it as "omit patches added upstream", while the opposite is meant. I'd prefer something like "Drop patches that have been merged upstream".
The wording "Drop upstream patches" is a bit confusing - one could read it as "omit patches added upstream", while the opposite is meant. I'd prefer something like "Drop patches that have been merged upstream".
I don't understand why patch 3004 is necessary. @PYTHON@ should be substituted during build, no? Moreover, I wonder if it's correct to hard-code python3 if this is supposed to be used for SLE12 SP4. You may need a conditional.
Hi Mwilck,
This patch is only used to fix the obs building error, the patch do not take effect, since I do not think our lvm2 test-suit package works before we begin to use it.
Thanks Gang
Hello Guys,
I update change log according to your comments, the new request is here https://build.opensuse.org/request/show/631017
Thanks Gang
Request History
ganghe created request
licensedigger accepted review
ok
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
dimstar_suse set openSUSE:Factory:Staging:J as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:J"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:J
dimstar accepted review
repo-checker accepted review
cycle and install check passed
dimstar_suse accepted review
ready to accept
dimstar_suse approved review
ready to accept
dimstar_suse accepted request
Accept to openSUSE:Factory
Hi Guys,
Update change log according to the reviewers' comments in request 630678, Please help to review this request asap, since our 12sp4 project is being blocked by this factory submission.
Thanks Gang
You do not need to repeat this everytime. (It's also not helping; contributors always have their own idea of a schedule.)
Just occured to me - is it wise to introduce in SLE12 SP4 a newer LVM2 version than in SLE15? Is there a FATE for that? I can't even see a SLE15 maintenance request.
It doesn't really matter for this factory submission, just wondering.
Hi Mwilck,
I am going to upgrade LVM2 to v2.02.180 in factory firstly, then I will upgrade LVM2 on SLE12SP4 to v2.02.180 (the same version), but on SLE12SP4, there will not be lvmlockd related support, we only support the existing features (e.g. clvmd).
Thanks Gang
Otherwise, I have no issues with this request.
Hello Guys,
How about this request's progress? since its status looks to be the same status " openSUSE:Factory:Staging:J" for three days.
Thanks Gang