Hello Guys,

Please help to review this request asap, the whole change(lvm2_v2_02_180) from my home project is not too much big, but the project will fix lvm2 two key feature problems (lvm2 mirror LV and pvmove), second, our 12sp4 project is being blocked by this factory submission.

Thanks Gang

Hi Guys,

Please help to review this request asap, since our 12sp4 project is being blocked by this factory submission.

Thanks Gang

Dominique Leuenberger (dimstar) - almost 6 years ago

reviewer

I'll try to find a staging space for this asap - with the issues around openQA of last week, things started piling up more than thet should.

OTOH: the changelog is clearly incomplete.

+- Update to LVM2.2.02.180

The standard decline message, which should have been given by @namtrac is:

Please be a bit more verbose in the changes entry ... (not just version number).

Please read https://en.opensuse.org/openSUSE:Howto_write_good_changes for more details about a good changelog entry.

Dominique Leuenberger (dimstar) - almost 6 years ago

reviewer

Or the ordering is a bit strange - some of the fixes mentioned are likely to be attributed to the update; possibly Ismail was nice enough to interpret it that way :)

The wording "Drop upstream patches" is a bit confusing - one could read it as "omit patches added upstream", while the opposite is meant. I'd prefer something like "Drop patches that have been merged upstream".

The wording "Drop upstream patches" is a bit confusing - one could read it as "omit patches added upstream", while the opposite is meant. I'd prefer something like "Drop patches that have been merged upstream".

I don't understand why patch 3004 is necessary. @PYTHON@ should be substituted during build, no? Moreover, I wonder if it's correct to hard-code python3 if this is supposed to be used for SLE12 SP4. You may need a conditional.

Gang He (ganghe) - almost 6 years ago

author source maintainer

Hi Mwilck,

This patch is only used to fix the obs building error, the patch do not take effect, since I do not think our lvm2 test-suit package works before we begin to use it.

Thanks Gang

Hello Guys,

I update change log according to your comments, the new request is here https://build.opensuse.org/request/show/631017

Thanks Gang