Overview

Request 640756 accepted

- Add go-1.11-compat-backport.patch for go1.11 compatibility.
* Tested with golang(API) == 1.10 and golang(API) == 1.11, OK
* Upstream git master commit
https://github.com/kubernetes-sigs/cri-o/commit/0bd30872028b5ed2d0eb7febb39f034b5f2da72a
contains 1 hunk adding missing argument in format string of
calls to:
# github.com/kubernetes-incubator/cri-o/lib
lib/container_server.go:309: Debugf call needs 1 arg but has 2 args
lib/container_server.go:317: Debugf call needs 1 arg but has 2 args
...
FAIL github.com/kubernetes-incubator/cri-o/lib [build failed]
Calls in question:
logrus.Debugf("loaded new pod sandbox %s", sandboxID, err)
logrus.Debugf("loaded new pod container %s", containerID, err)
require another argument to the string format (": %v" per upstream):
logrus.Debugf("loaded new pod sandbox %s: %v", sandboxID, err)
logrus.Debugf("loaded new pod container %s: %v", containerID, err)
Patch contents not available in upstream cri-o released versions:
cri-o-1.11.3
cri-o-1.11.4
cri-o-1.11.5
cri-o-1.11.6
Filed upstream issue requesting patch contents in released version:
https://github.com/kubernetes-sigs/cri-o/issues/1827

Loading...
Request History
Richard Brown's avatar

RBrownSUSE created request

- Add go-1.11-compat-backport.patch for go1.11 compatibility.
* Tested with golang(API) == 1.10 and golang(API) == 1.11, OK
* Upstream git master commit
https://github.com/kubernetes-sigs/cri-o/commit/0bd30872028b5ed2d0eb7febb39f034b5f2da72a
contains 1 hunk adding missing argument in format string of
calls to:
# github.com/kubernetes-incubator/cri-o/lib
lib/container_server.go:309: Debugf call needs 1 arg but has 2 args
lib/container_server.go:317: Debugf call needs 1 arg but has 2 args
...
FAIL github.com/kubernetes-incubator/cri-o/lib [build failed]
Calls in question:
logrus.Debugf("loaded new pod sandbox %s", sandboxID, err)
logrus.Debugf("loaded new pod container %s", containerID, err)
require another argument to the string format (": %v" per upstream):
logrus.Debugf("loaded new pod sandbox %s: %v", sandboxID, err)
logrus.Debugf("loaded new pod container %s: %v", containerID, err)
Patch contents not available in upstream cri-o released versions:
cri-o-1.11.3
cri-o-1.11.4
cri-o-1.11.5
cri-o-1.11.6
Filed upstream issue requesting patch contents in released version:
https://github.com/kubernetes-sigs/cri-o/issues/1827


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Ismail Dönmez's avatar

namtrac accepted review


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:J as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:J"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked openSUSE:Factory:Staging:J


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Dominique Leuenberger's avatar

dimstar_suse accepted review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse approved review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by