Overview

Request 682299 superseded

No description set
Loading...
Request History
James Fehlig's avatar

jfehlig created request


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Staging Bot's avatar

staging-bot set openSUSE:Factory:Staging:F as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:F"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:F


Ismail Dönmez's avatar

namtrac declined review

+%post daemon-driver-network
+%if %{with_firewalld_zone}
+ %firewalld_reload
+%endif
+
+%postun daemon-driver-network
+%if %{with_firewalld_zone}
+ %firewalld_reload
+%endif
+

When firewalld_zone is disabled, you'll end up with empty post/postun which will fail. Instead wrap these two properly:

+%if %{with_firewalld_zone}
+%post daemon-driver-network
+ %firewalld_reload
+
+%postun daemon-driver-network
+ %firewalld_reload
+%endif


Ismail Dönmez's avatar

namtrac declined request

+%post daemon-driver-network
+%if %{with_firewalld_zone}
+ %firewalld_reload
+%endif
+
+%postun daemon-driver-network
+%if %{with_firewalld_zone}
+ %firewalld_reload
+%endif
+

When firewalld_zone is disabled, you'll end up with empty post/postun which will fail. Instead wrap these two properly:

+%if %{with_firewalld_zone}
+%post daemon-driver-network
+ %firewalld_reload
+
+%postun daemon-driver-network
+ %firewalld_reload
+%endif


James Fehlig's avatar

jfehlig superseded request

superseded by 682527

openSUSE Build Service is sponsored by