This request is superseded by
request 691479
(Show diff)
Overview
Request 690980 superseded
submit new version 4.2.1
- Created by yast-team
- In state superseded
- Superseded by 691479
-
Open review for
opensuse-review-team
- Open review for openSUSE:Factory:Staging:J
Loading...
Request History
yast-team created request
submit new version 4.2.1
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
staging-bot set openSUSE:Factory:Staging:F as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:F"
staging-bot accepted review
Picked openSUSE:Factory:Staging:F
dimstar_suse set openSUSE:Factory:Staging:J as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:J"
dimstar_suse accepted review
Moved to openSUSE:Factory:Staging:J
superseded by 691479
Shouldn't this be a Requires: instead of a BuildRequires?
We neeed BuildRequires because we run some unit tests against that package during build.
For Requires it's a question, I do not think it is strictly needed. It depends whether the final product actually uses that NTP dialog or not.
If it does than the Requires should be added to the respective product skelcd package, like https://github.com/yast/skelcd-control-openSUSE/blob/392dba66dc012fe2491cb27b9d8430335e9bc093/package/skelcd-control-openSUSE.spec#L65
Omitting the Requires allows having a smaller inst-sys (without yast2-ntp-client) if it is not used during installation.
Yes, it makes sense - it just looked suspicious that all other yast2- dependencies were Requires and not only BuildRequires.
We seem to end up with a cycle here: