Shouldn't this be a Requires: instead of a BuildRequires?

We neeed BuildRequires because we run some unit tests against that package during build.

For Requires it's a question, I do not think it is strictly needed. It depends whether the final product actually uses that NTP dialog or not.

If it does than the Requires should be added to the respective product skelcd package, like https://github.com/yast/skelcd-control-openSUSE/blob/392dba66dc012fe2491cb27b9d8430335e9bc093/package/skelcd-control-openSUSE.spec#L65

Omitting the Requires allows having a smaller inst-sys (without yast2-ntp-client) if it is not used during installation.

Fabian Vogt (favogt) - over 5 years ago

Yes, it makes sense - it just looked suspicious that all other yast2- dependencies were Requires and not only BuildRequires.

We seem to end up with a cycle here:

Package yast2-installation appears in cycle yast2-installation/yast2-ntp-client
Package yast2-ntp-client appears in cycle yast2-installation/yast2-ntp-client