Overview
Request 709948 accepted
Add support for zstd payloads and build_*flags macros
Note that this will require adding `Preinstall: libzstd1` to the `openSUSE:Factory` definition because libzstd is now a dependency of rpm itself.
- Created by Pharaoh_Atem
- In state accepted
Request History
Pharaoh_Atem created request
Add support for zstd payloads and build_*flags macros
Note that this will require adding `Preinstall: libzstd1` to the `openSUSE:Factory` definition because libzstd is now a dependency of rpm itself.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
namtrac accepted review
mlschroe accepted review
Fine with me.
maxlin_factory set openSUSE:Factory:Staging:A as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:A"
maxlin_factory accepted review
Picked openSUSE:Factory:Staging:A
dimstar_suse accepted review
ready to accept
dimstar_suse approved review
ready to accept
dimstar_suse accepted request
Accept to openSUSE:Factory
yeah, not going to happen like this...
this pulls zstd into ring0 (which is probably ok) - but zstd pulls googletest with it - and googletest is a lost cause.
So if this is really supposed to happen, I need a zstd that can actually be used in a bootstrap-like mini distro
How would you like that addressed? I'm not really sure how to deal with that problem, other than "disable running tests in zstd builds"...
If tests are ever to be enabled, that should be a separate spec file (like is done elsewhere).
https://build.opensuse.org/request/show/709960
I don't think the zstd build needs googletest at all. So I'd just remove that BuildRequires from its spec.
(googletest seems to be only needed for testing pzstd, and the test-pzstd line in commented out in the spec file. So it seems that the googletest buildreq should also be commented out.)
@RBrownSUSE, @mlschroe: review reminder