Overview

Request 749516 superseded

update to rpm-4.15.1

Loading...

Dominique Leuenberger's avatar

rpm-build gaining a dependency on python3-setuptools is fatal - this can't possibly become a ring0 package


Michael Schröder's avatar

I'm not sure why Neal added that, I think the python3 requires would have been enough.


Neal Gompa's avatar

The pkg_resources import used by the dependency generator when it hits valid python egg/wheel/dist metadata is part of the setuptools module.

I suppose that most cases won't trigger this in a scenario where setuptools won't also be in the build environment (since the import is conditionally invoked), but in theory it's possible to have a legacy distutils-based module with zero deps that pull in setuptools, which would make the dep generator break.

Would a conditional Requires work here?

Like, for example:

Requires: (python3-setuptools if (python-rpm-macros or python3-devel or python2-devel))

Dominique Leuenberger's avatar

Rich deps (hard deps) are a huge problem: as soon as we start adding such things, we block all kind of zypper dup from openSUSE versions to TW where $old-version does not have rpm/zypp with rich dep support.

So far we limited ourselves to weak rich deps, so they can 'simply be ignored' (not perfect, but ok-ish)


Neal Gompa's avatar

But SLE 15 supports this, so SLE 15 to TW/SLE 16 should work.

The troublesome one would be SLE 12 to SLE 16, I guess. But are direct upgrades from SLE 12 to SLE 16 going to be supported?


Michael Schröder's avatar

Why would pyhon2-devel require the setuptools from python3?

Anyway, wouldn't it be better if python3-devel would require python3-setuptools?


Neal Gompa's avatar

The idea is any event where it's likely that the dep generator would be used would trigger the inclusion of the setuptools dependency.

And ordinarily, it'd be fine if it was required by python3-devel/python2-devel, but most Python packages in openSUSE do not have a BuildRequires for it, so there's still a huge gap.


Michael Schröder's avatar

Maybe, but the old rpm packages didn't have a setuptools requires and nobody complaint, so we're not talking about a regression here.


Dominique Leuenberger's avatar

rpm-build gaining a dependency on python3-setuptools is fatal - this can't possibly become a ring0 package

Request History
Michael Schröder's avatar

mlschroe created request

update to rpm-4.15.1


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:N as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:N"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked openSUSE:Factory:Staging:N


Ismail Dönmez's avatar

namtrac accepted review


Michael Schröder's avatar

mlschroe superseded request

superseded by 749859

openSUSE Build Service is sponsored by