Overview
Request 764969 superseded
- bsc#1160729: Make valid shell check only a warning
* Add shadow-4.8-shell-check.patch
- Update to 4.8:
* Initial optional bcrypt support.
* Make build/install of 'su' optional.
* Fix for vipw not resuming correctly when suspended
* Sync password field descriptions in manpages
* Check for valid shell argument in useradd
* Allow translation of new strings through POTFILES.in
* Migrate to itstool for translations
* Migrate to new SELinux api
* Support --enable-vendordir
* pwck: Only check homedir if set and not a system user
* Support nonstandard usernames
* sget{pw,gr}ent: check for data at EOL
* Add YYY-MM-DD support in chage
* Fix failing chmod calls for suidubins
* Fix --sbindir and --bindir for binary installations
* Fix LASTLOG_UID_MAX in login.defs
* Fix configure error with dash
- Remove because upstreamed:
* libeconf.patch
* shadow-usermod-variable.patch
- Rebase:
* shadow-login_defs-unused-by-pam.patch
* chkname-regex.patch
* shadow-util-linux.patch
* shadow-login_defs-comments.patch
- Add shadow-4.8-selinux-include.patch
- Created by jubalh
- In state superseded
- Supersedes 757530
- Superseded by 765745
-
Open review for
factory-staging
This change causes openQA failures, as:
2019-12-30 11:28:11 <5> install(3531) [zypp] Exception.cc(log):166 RpmDb.cc(doInstallPackage):2123 THROW: Subprocess failed. Error: RPM failed: groupadd -r -g 65533 nogroup 2019-12-30 11:28:11 <5> install(3531) [zypp] Exception.cc(log):166 groupadd -r -g 65534 nobody 2019-12-30 11:28:11 <5> install(3531) [zypp] Exception.cc(log):166 useradd -r -s /sbin/nologin -c "nobody" -g nobody -d /var/lib/nobody -u 65534 nobody 2019-12-30 11:28:11 <5> install(3531) [zypp] Exception.cc(log):166 useradd: invalid shell '/sbin/nologin' 2019-12-30 11:28:11 <5> install(3531) [zypp] Exception.cc(log):166 error: %prein(system-user-nobody-20170617-9.55.noarch) scriptlet failed, exit status 3 2019-12-30 11:28:11 <5> install(3531) [zypp] Exception.cc(log):166 error: system-user-nobody-20170617-9.55.noarch: install failed
I somewhat think it's checking against /etc/shells - which means we need to adapt aaa_base to add /sbin/nologin there as a valid shell
https://github.com/openSUSE/aaa_base/pull/67
huh, you created https://github.com/shadow-maint/shadow/pull/187 yourself, you should know it's not /etc/shells but needs to be an executable. Means the failure is probably due to missing util-linux. The change to require an existing shell in useradd is harmful for initial installation.
Request History
jubalh created request
- bsc#1160729: Make valid shell check only a warning
* Add shadow-4.8-shell-check.patch
- Update to 4.8:
* Initial optional bcrypt support.
* Make build/install of 'su' optional.
* Fix for vipw not resuming correctly when suspended
* Sync password field descriptions in manpages
* Check for valid shell argument in useradd
* Allow translation of new strings through POTFILES.in
* Migrate to itstool for translations
* Migrate to new SELinux api
* Support --enable-vendordir
* pwck: Only check homedir if set and not a system user
* Support nonstandard usernames
* sget{pw,gr}ent: check for data at EOL
* Add YYY-MM-DD support in chage
* Fix failing chmod calls for suidubins
* Fix --sbindir and --bindir for binary installations
* Fix LASTLOG_UID_MAX in login.defs
* Fix configure error with dash
- Remove because upstreamed:
* libeconf.patch
* shadow-usermod-variable.patch
- Rebase:
* shadow-login_defs-unused-by-pam.patch
* chkname-regex.patch
* shadow-util-linux.patch
* shadow-login_defs-comments.patch
- Add shadow-4.8-selinux-include.patch
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
namtrac accepted review
dimstar_suse set openSUSE:Factory:Staging:B as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:B"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:B"
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:B"
superseded by 765745
Please link-up with sec team about that
Need sec involvement for suid binaries (or packaging change)