Overview
Request 843283 accepted
- Created by kstreitova
- In state accepted
Request History
kstreitova created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse added openSUSE:Factory:Staging:adi:27 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:27"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:27"
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:adi:27"
dimstar_suse added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:33"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:33"
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:adi:33"
dimstar_suse added openSUSE:Factory:Staging:adi:20 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:20"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:20"
namtrac accepted review
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:adi:20 got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:adi:20 got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:adi:20 got accepted.
@kstreitova This doesn't look good or mentioned in the changes file:
-export CFLAGS="%{optflags} -fpie -fPIE" -export LDFLAGS="-pie -Wl,-z,relro,-z,now"You are right. @mkraus, did you have any particular reason for this or is this just a mistake? Thanks!
These flags are default now, so I dropped them. I indeed forgot to mention them in the changes though.