Overview
@sndirsch Your code-changes are no-op, only shebang change is enough.
Sorry, I don't understand. What's wrong with my submitrequest?
- print(', '.join(ignored_arguments))
+ print((', '.join(ignored_arguments)))
[...]
- print('Port %d is already used'%port)
+ print(('Port %d is already used'%port))
Both parts, before-and-after works the same on python2 and python3, you only need
-#!/usr/bin/env python +#!/usr/bin/python3
part.
Honestly I didn't understand why 2to3 added the brackets. It looked weird to me, but I'm not a Python expert.
Request History
sndirsch created request
- x11vnc wrapper script: converted to python3 (boo#1179592)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
namtrac accepted review
dimstar_suse set openSUSE:Factory:Staging:E as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:E"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:E"
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:E got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:E got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:E got accepted.
