Overview
Request 882082 superseded
* Build and (manually) install deprecated qhull library as part of qhull library and devel package; some apps (e.g. octave) still depend on this.
* Move the qhull_r libs, headers, related files into new shared lib libqhull_r and qhull_r-devel packages as appropriate.
* Move qhullcpp library, headers, and pkgconfig file into separate qhullcpp-devel-static package.
* qhullcpp is only supported as static library and needs to be built with "-ffat-lto-objects"; add this to CXXFLAGS.
* Delete unnecessary pkgconfig files corresponding to static libs that are not built/installed.
- Created by badshah400
- In state superseded
- Superseded by 884737
-
Open review for
StefanBruens
Request History
badshah400 created request
* Build and (manually) install deprecated qhull library as part of qhull library and devel package; some apps (e.g. octave) still depend on this.
* Move the qhull_r libs, headers, related files into new shared lib libqhull_r and qhull_r-devel packages as appropriate.
* Move qhullcpp library, headers, and pkgconfig file into separate qhullcpp-devel-static package.
* qhullcpp is only supported as static library and needs to be built with "-ffat-lto-objects"; add this to CXXFLAGS.
* Delete unnecessary pkgconfig files corresponding to static libs that are not built/installed.
badshah400 added StefanBruens as a reviewer
Stefan, when you have the time, could you please look at this (major?) reorganisation of the package. I have only checked that octave (which depends on the old qhull API) now builds with qhull support again, but would love your inputs on this. Thanks.
@badshah400: See https://build.opensuse.org/package/show/home:StefanBruens:branches:science/octave
and
https://savannah.gnu.org/bugs/index.php?60016
That is awesome, thanks a lot.
For this sr then:
Providing both libqhull and libqhull_r actually poses a risk - both libs provide the exact same functions/symbols, but with different function parameters. In case a program loads both libraries (e.g. via some plugin mechanism) the code will very likely crash.
From the disassembly of both versions, it is hard to justify any performance difference.
The static libqhullcpp may have some use cases outside distribution packages, so your call on this.
OK, I will resubmit this after cleaning it up soon. Thanks for the review.
@Dmitry_R, @Mailaender, @StefanBruens, @TheBlackCat, @adrianSuSE, @anag, @badshah400, @cjunghans, @dstoecker, @eeich, @kwk, @mslacken, @openfoam, @psmt: review reminder