Overview
Request 884737 accepted
- Drop deprecated (non-reentrant) qhull headers since we don't
provide the corresponding shared lib.
- Move the qhull_r libs, headers, related files into new shared
lib libqhull_r and qhull_r-devel packages as appropriate; have
qhull_r-devel provide qhull-devel.
- Move qhullcpp library, headers, and pkgconfig file into separate
qhullcpp-devel-static package.
- qhullcpp is only supported as static library and needs to be
built with "-ffat-lto-objects"; add this to CXXFLAGS.
- Delete unnecessary pkgconfig files corresponding to static libs
that are not built/installed.
- Created by badshah400
- In state accepted
- Supersedes 882082
@badshah400:
See https://build.opensuse.org/package/show/home:StefanBruens:branches:science/octave
and
https://savannah.gnu.org/bugs/index.php?60016
That is awesome, thanks a lot.
For this sr then:
- Would you suggest I drop building the old qhull entirely? I don't know how many other packages there may be still depending on it -- plplot is one example. Besides, upstream does say [http://www.qhull.org/html/qh-code.htm#reentrant], "libqhull will be supported indefinitely, improvements may not be implemented" and that "reentrant qhull is 1-2% slower than non-reentrant qhull".
- Are you ok with the qhullcpp and qhull_r-devel package split? Or should we drop the former because it does not build a shared lib yet?
Providing both libqhull and libqhull_r actually poses a risk - both libs provide the exact same functions/symbols, but with different function parameters. In case a program loads both libraries (e.g. via some plugin mechanism) the code will very likely crash.
From the disassembly of both versions, it is hard to justify any performance difference.
The static libqhullcpp may have some use cases outside distribution packages, so your call on this.
OK, I will resubmit this after cleaning it up soon. Thanks for the review.
@Dmitry_R, @Mailaender, @StefanBruens, @TheBlackCat, @adrianSuSE, @anag, @badshah400, @cjunghans, @dstoecker, @eeich, @kwk, @mslacken, @openfoam, @psmt: review reminder
Request History
badshah400 created request
- Drop deprecated (non-reentrant) qhull headers since we don't
provide the corresponding shared lib.
- Move the qhull_r libs, headers, related files into new shared
lib libqhull_r and qhull_r-devel packages as appropriate; have
qhull_r-devel provide qhull-devel.
- Move qhullcpp library, headers, and pkgconfig file into separate
qhullcpp-devel-static package.
- qhullcpp is only supported as static library and needs to be
built with "-ffat-lto-objects"; add this to CXXFLAGS.
- Delete unnecessary pkgconfig files corresponding to static libs
that are not built/installed.
dstoecker accepted request
@Dmitry_R, @Mailaender, @StefanBruens, @TheBlackCat, @adrianSuSE, @anag, @badshah400, @cjunghans, @dstoecker, @eeich, @kwk, @mslacken, @openfoam, @psmt: review reminder