This request is superseded by
request 927601
(Show diff)
Overview
Request 927495 superseded
- Update to version 2.2.0
- Created by mnhauke
- In state superseded
-
Package maintainer:
fstrba
- Supersedes 922657
- Superseded by 927601
Loading...
target maintainer
The Fedora website for mingw states that the %_mingw64_debug_package macro must be after %decription to avoid problems with the rpmlint tool.
Also use %_mingw64_debug_package and %_mingw64_package_header_debug without parentheses. I know that both forms were used in the specification files of the target project (430 without brackets and 60 with brackets). However, this is history as I now clean up all the spec files in this context, (no brackets for these macros as most packages don't use them).
This can cause confusion as brackets are used elsewhere in the spec file. Currently in other obs projects the use of brackets is being reduced more and more, so consider removing them here as well (e.g. in the file list).
Login required, please
login
in order to comment
Is that line optional and only needed in special cases ?
You removed all other brackets in the %files section, but not here - is that indentional ? If not, please remove the brackets here also.
I do not see any usage of the c++ compiler - I think this dependency can be dropped
In the build log there is
Please use a valid license
As general rule: keep an eye on the rpmlint warnings in the build log.
BuildRoot is not longer needed ... https://github.com/rpm-software-management/spec-cleaner/issues/195