Overview
Request 927601 superseded
- Update to version 2.2.0
- Created by mnhauke
- In state superseded
- Package maintainer: fstrba
- Supersedes 927495
- Superseded by 928032
- BuildRoot: %{_tmppath}/%{name}-%{version}-build
Is that line optional and only needed in special cases ?
+%{_mingw64_bindir}
You removed all other brackets in the %files section, but not here - is that indentional ? If not, please remove the brackets here also.
+BuildRequires: mingw64-cross-gcc-c++
I do not see any usage of the c++ compiler - I think this dependency can be dropped
In the build log there is
mingw64-glew.src: W: invalid-license Other uncritical OpenSource License The value of the License tag was not recognized. Known values are:
Please use a valid license
As general rule: keep an eye on the rpmlint warnings in the build log.
BuildRoot is not longer needed ... https://github.com/rpm-software-management/spec-cleaner/issues/195
I see two remaining issues:
This is already a dependency of
mingw64-cross-gcc
(seerpm -q --requires mingw64-cross-gcc | grep mingw64
) and can be removed.A similar request is required for mingw32-glew.